RE: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4

From: Marek Szyprowski
Date: Mon Mar 15 2010 - 02:46:47 EST


Hello,

On Wednesday, March 10, 2010 6:07 PM Mark Brown wrote:

> On Wed, Mar 10, 2010 at 08:29:40AM +0800, axel lin wrote:
> > From: Axel Lin <axel.lin@xxxxxxxxx>
> > Date: Tue, 9 Mar 2010 16:53:59 +0800
> > Subject: [PATCH] lp3971: Fix setting val for LDO2 and LDO4
> >
> > In lp3971_ldo_set_voltage function, it requires val to left shift 4
> > bits for LDO2 and LDO4.
> > This patch fix this issue.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> but I really would prefer to see one of the Samsung folks comment.

Acked-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>

This was definitely a bug. Thanks for spotting it.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/