Re: [PATCH 1/2] kmod: add init function to usermodehelper

From: Oleg Nesterov
Date: Mon Mar 15 2010 - 13:36:54 EST


On 03/15, Neil Horman wrote:
>
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -116,27 +116,16 @@ int __request_module(bool wait, const char *fmt, ...)
>
> trace_module_request(module_name, wait, _RET_IP_);
>
> - ret = call_usermodehelper(modprobe_path, argv, envp,
> - wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC);
> + ret = call_usermodehelper_fns(modprobe_path, argv, envp,
> + wait ? UMH_WAIT_PROC : UMH_WAIT_EXEC,
> + NULL, NULL, NULL);

This change looks unnecessary, but doesn't hurt.

Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/