Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.
From: Greg KH
Date: Mon Mar 15 2010 - 15:39:38 EST
On Mon, Mar 15, 2010 at 08:14:27PM +0200, Pekka Enberg wrote:
> Lars Lindley wrote:
> >On 2010-03-15 17:52, Pekka Enberg wrote:
> >>Dan Carpenter wrote:
> >>>On Mon, Mar 15, 2010 at 05:36:13PM +0100, Lars Lindley wrote:
> >>>>I fixed most of the problems found by checkpatch.pl.
> >>>>Some long lines are left and some KERN_..
> >>>>This is a new revised patch against master with changes
> >>>>after comments from Stefan Richter and Dan Carpenter.
> >>>>Forget the old one.
> >>>>
> >>>>Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
> >>>>Acked-by: Pavel Machek <pavel@xxxxxx>
> >>>Acked-by: Dan Carpenter <error27@xxxxxxxxx>
> >>It's pretty difficult to say if anything changed based on the diff so
> >>would you mind posting before and after output of 'size mds.o', please?
> >>
> >Hi Pekka.
> >
> >Before:
> >lali@lazer2 ~/linux3/linux-2.6 $ size drivers/staging/winbond/mds.o
> > text data bss dec hex filename
> > 2804 0 0 2804 af4 drivers/staging/winbond/mds.o
> >
> >After:
> >lali@lazer2 ~/linux2/linux-2.6 $ size drivers/staging/winbond/mds.o
> > text data bss dec hex filename
> > 2804 0 0 2804 af4 drivers/staging/winbond/mds.o
> >
> >diff:
> >lali@lazer2 ~/linux2/linux-2.6 $ diff ../../linux3/linux-2.6/drivers/staging/winbond/mds.o drivers/staging/winbond/mds.o
> >lali@lazer2 ~/linux2/linux-2.6 $
> >
> >linux3 is a clean tree and linux2 the one i'm working on..
>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>
> Greg, can you pick up my typedef cleanups and this patch to -staging?
Yes, will do.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/