Re: [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families

[Luis R. Rodriguez]

On Fri, Mar 12, 2010 at 5:12 PM, Greg KH <gregkh@xxxxxxx> wrote:
> 2.6.33-stable review patch. ÂIf anyone has any objections, please let me know.

This was intended for 2.6.32 as well. Thanks

  Luis
> -----------------
>
> From: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
>
> commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream.
>
> The newer single chip hardware family of chipsets have not been
> experiencing issues with power saving set by default with recent
> fixes merged (even into stable). The remaining issues are only
> reported with AR5416 and since enabling PS by default can increase
> power savings considerably best to take advantage of that feature
> as this has been tested properly.
>
> For more details on this issue see the bug report:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14267
>
> We leave AR5416 with PS disabled by default, that seems to require
> some more work.
>
> Cc: Peter Stuge <peter@xxxxxxxx>
> Cc: Justin P. Mattock Â<justinmattock@xxxxxxxxx>
> Cc: Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> ---
> Âdrivers/net/wireless/ath/ath9k/main.c | Â Â5 ++++-
> Â1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1849,6 +1849,8 @@ bad_free_hw:
>
> Âvoid ath_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
> Â{
> + Â Â Â struct ath_hw *ah = sc->sc_ah;
> +
> Â Â Â Âhw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
> Â Â Â Â Â Â Â ÂIEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
> Â Â Â Â Â Â Â ÂIEEE80211_HW_SIGNAL_DBM |
> @@ -1866,7 +1868,8 @@ void ath_set_hw_capab(struct ath_softc *
> Â Â Â Â Â Â Â ÂBIT(NL80211_IFTYPE_ADHOC) |
> Â Â Â Â Â Â Â ÂBIT(NL80211_IFTYPE_MESH_POINT);
>
> - Â Â Â hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> + Â Â Â if (AR_SREV_5416(ah))
> + Â Â Â Â Â Â Â hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>
> Â Â Â Âhw->queues = 4;
> Â Â Â Âhw->max_rates = 4;
>
>
> _______________________________________________
> Stable-review mailing list
> Stable-review@xxxxxxxxxxxxxxxx
> http://linux.kernel.org/mailman/listinfo/stable-review
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/