Re: [PATCH] proc: Report file name on detected read_proc overflow

[Frans Pop]

Jan Kiszka wrote:
> -                                      "proc_file_read: Apparent buffer overflow!\n");
> +                                      "proc_file_read: Apparent buffer "
> +                                      "overflow reading \"%s\"!\n",
> +                                      file->f_path.dentry->d_name.name);

I think it would be good to keep "overflow" on the first line as that
may be what people will grep the source for. And maybe use single quotes
around the file name. So:

+                                      "proc_file_read: Apparent buffer overflow "
+                                      "reading '%s'!\n",
+                                      file->f_path.dentry->d_name.name);

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/