Re: [PATCH 0/2] perf newt: Zoom operations

[Arnaldo Carvalho de Melo]

Em Sun, Apr 04, 2010 at 11:58:27AM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxx> wrote:
> > Arnaldo Carvalho de Melo (2):
> >   perf newt: Add a "Zoom into foo.so DSO" and reverse operations
> >   perf TUI: Add a "Zoom into COMM(PID) thread" and reverse operations
> 
> Pulled, thanks Arnaldo!
> 
> There's still a few basic usability glitches that i've noticed:
> 
>  - it's not clear how to zoom out, once zoomed in

I'll use the title line to store the name of the DSO and Thread and the 
help line to state that to zoom out, press -> + zoom out, and I think
that it is a good idea to use 'd' and 'D' to zoom in/out of DSOs and 't'
and 'T' to zoom in/out of DSOs.
 
>  - there's no help screen and no help line for people to see what can be 
>    done on a given screen. While it's good that the intuitive things work
>    by default (arrow keys, escape, enter, etc.), there should also be additional
>    visual information about what can be done.

F1 and textboxes with a short description of what can be done given for
the first time or till the user presses "Suppress these info boxes" will
be added.
 
>  - i think double escape should exit, right now it stays at the 'are you sure'
>    screen

Here I thought that something had to be done to avoid that accidentally
pressing ESC two times or having "Yes" as default option, trowing away
possibly a long processed session, what do others think about it?

I think that ESC + "Yes" as a default may be ok, as two keys need to be
pressed (ESC + Enter), enough warning/confirmation, I gues, right?

> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/