Re: [PATCH][RESEND] x86: Do not write to VGA memory space if CONFIG_VGA_CONSOLEis undefined

[H. Peter Anvin]

On 04/05/2010 02:11 PM, H. Peter Anvin wrote:
> On 04/05/2010 02:04 PM, Guenter Roeck wrote:
>>
>> Would you accept a minimized patch like this ?
>>
>>  /* Direct interface for emergencies */
>> +#ifdef CONFIG_VGA_CONSOLE
>>  static struct console *early_console = &early_vga_console;
>> +#else
>> +static struct console *early_console = &early_serial_console;
>> +#endif
>>  static int __initdata early_console_initialized;
>>
>> This would prevent the problem while minimizing changes, and at the same
>> time permit early messages to be written to the serial console.
>>
> 
> I'm unhappy about it, because *those early messages shouldn't exist in
> the first place*.  It seems to be an indication that we're invoking
> setup_early_printk() too late.  The whole playing around with max_xpos
> and max_ypos instead of using boot_params.screen_info directly is
> particularly bleacherous.
> 
> I would at least like to see if the improper invocation of
> early_printk() can be avoided.
> 

Specifically: is this anything other than "Kernel alive\n"?

If it's just "Kernel alive\n" I say drop it on the floor.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/