Re: [PATCH] proc: pagemap: Hold mmap_sem during page walk

[KAMEZAWA Hiroyuki]

On Fri, 2 Apr 2010 09:30:58 -0500
Matt Mackall <mpm@xxxxxxxxxxx> wrote:

> On Fri, Apr 02, 2010 at 09:11:29AM +0900, KAMEZAWA Hiroyuki wrote:
> 
> >  	int ret = -ESRCH;
> ...
> > +	pm.len = PM_ENTRY_BYTES * (PAGEMAP_WALK_SIZE >> PAGE_SHIFT);
> > +	pm.buffer = kmalloc(pm.len, GFP_TEMPORARY);
> > +	if (!pm.buffer)
> >  		goto out_mm;
> ...
> >  out_mm:
> >  	mmput(mm);
> 
> Looks like this gets the wrong return code?
> 
I'm sorry. And thank you for pointing out.
I confirmed merged one has fixed code.

Regards,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/