Re: Random scheduler/unaligned accesses crashes with perf lockevents on sparc 64

[Steven Rostedt]

On Tue, 2010-04-06 at 10:46 -0700, David Miller wrote:
> From: Steven Rostedt <srostedt@xxxxxxxxxx>
> Date: Tue, 06 Apr 2010 09:41:04 -0400
> 
> > It's best to send to my rostedt@xxxxxxxxxxx account, just like it is
> > best to send to your davem@xxxxxxxxxxxxx ;-)
> 
> Ok then you should, like me, use it in your commits :-)
> 

My SoB is rostedt@xxxxxxxxxxx, my commits are srostedt@xxxxxxxxxx just
because I want to give credit to the one that pays me for making those
commits ;-)


> > What about removing the logic from the ring buffer and moving it to the
> > TRACE_EVENT() macros as I suggested above?
> 
> No, that makes no sense, just align the data types properly
> instead of making every single access site pay the price.

OK

> 
> Just fix the CPP test to handle 32-bit platforms with slow
> mis-alignment handling, everything else seems to be working properly
> after I fixed the NMI issues on sparc64.

A little more work will need to be done since on 32bit, the page headers
are 12 bytes, not 16, so we start off without being aligned 8bytes. But
that too is fixable.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/