Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmasof a mergeable VMA

[Linus Torvalds]

On Wed, 7 Apr 2010, Linus Torvalds wrote:
> 
> In the long run, it would be nicer to actually return an error from the 
> mmap() that fails, but that's more complicated, and as mentioned, it's not 
> what the old code used to do either (since the failure point was always at 
> the page fault stage).

Put another way: I'm not proud of it, but the new code isn't any worse 
than what we used to have, and I think the new code is _fixable_.

The easiest way to do that would likely be to pre-allocate the anon_vma 
struct (and anon_vma_chain), and pass it down to anon_vma_prepare. That 
way anon_vma_prepare() itself can never fail, and all we need to do is a 
simple allocation earlier in the call-chain.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/