Re: [PATCH 7/8] USB: testusb: imported David Brownell's USBtesting application

[Heikki Krogerus]

Hi,

If this is going into kernel then..

On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:

...

> +       if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> +               fputs ("usbfs files are missing\n", stderr);
> +               return -1;
> +       }

Is this needed?

> +
> +       /* collect and list the test devices */
> +       if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {

How about "/dev/bus/usb" instead? Some distributions do not enable
sysfs in their default kernels anymore.

> +               fputs ("ftw failed; is usbfs missing?\n", stderr);
> +               return -1;
> +       }

br,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/