Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

From: Changli Gao
Date: Sun Apr 25 2010 - 05:33:32 EST


On Sun, Apr 25, 2010 at 5:19 PM, <xiaohui.xin@xxxxxxxxx> wrote:
> +static int dev_is_mpassthru(struct net_device *dev)
> +{
> + Â Â Â if (dev && dev->mp_port)
> + Â Â Â Â Â Â Â return 1;
> + Â Â Â return 0;
> +}
> +

Please make it a inline function. And you would write it with less
lines of code.

return dev && dev->mp_port;


--
Regardsï
Changli Gao(xiaosuo@xxxxxxxxx)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/