Re: [patch] gpio: potential null dereference

[Daniel Glöckner]

On 04/27/2010 11:05 AM, Dan Carpenter wrote:
> On Tue, Apr 27, 2010 at 01:05:15AM +0200, Daniel Glöckner wrote:
>> On Mon, Apr 26, 2010 at 09:25:20PM +0200, Dan Carpenter wrote:
>>> Smatch found a potential null dereference in gpio_setup_irq().  The 
>>> "pdesc" variable is allocated with idr_find() that can return NULL.  If
>>> gpio_setup_irq() is called with 0 as gpio_flags and "pdesc" is null, it
>>> would OOPs here.
>> idr_find() doesn't allocate, idr_get_new_above() does.
>> Assuming idr_find() never fails for an id if idr_get_new_above()
>> successfully allocated that id, I don't think we can reach that
>> line with pdesc being NULL:
>>
>> - There are two gotos leading to free_sd
>> - #2 is after a block that allocates pdesc
>> - #1 is in an if (!gpio_flags) block
>> - We exit early if ((desc->flags & GPIO_TRIGGER_MASK) == gpio_flags)
>> - Therefore (desc->flags & GPIO_TRIGGER_MASK) must be != 0 to reach #1
>> - Trigger flags are added to desc->flags only after we have
>>   successfully allocated pdesc (i.e. right before return 0)
>> - We start off with no trigger flags set
>>
> 
> Are you sure?  If we know that the call to idr_find() returns a valid 
> pointer we could remove a lot of error handling code...

It returns a valid pointer iff (desc->flags & GPIO_TRIGGER_MASK).

When !(desc->flags & GPIO_TRIGGER_MASK) it returns NULL and everything
gets allocated (unless !gpio_flags as well). What you wanted to remove
is the allocation code, not error handling code. It is always run when
the trigger is set from "none" to something else.

  Daniel

-- 
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax -11, Bahnhofsallee 1b, 37081 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/