Re: [PATCH 1/2] acpi-cpufreq: Fix CPU_ANY CPUFREQ_{PRE,POST}CHANGE notification

[Venkatesh Pallipadi]

Acked-by: Venkatesh Pallipadi <venki@xxxxxxxxxx>

On Tue, Apr 27, 2010 at 7:57 AM, Thomas Renninger <trenn@xxxxxxx> wrote:
>
> This has been found be review.
> Currently PRE/POSTCHANGE events seem to only be thrown for one core
> if the BIOS tells us to run in CPU_ANY mode (switching one/any
> of the depending cores is enough).
>
> Signed-off-by: Thomas Renninger <trenn@xxxxxxx>
> CC: venki@xxxxxxxxxx
> CC: davej@xxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> CC: cpufreq@xxxxxxxxxxxxxxx
> CC: linux-perf-users@xxxxxxxxxxxxxxx
> CC: linux-trace-users@xxxxxxxxxxxxxxx
> CC: x86@xxxxxxxxxx
> CC: robert.schoene@xxxxxxxxxxxxx
> ---
>  arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> index 4591680..c6de3a9 100644
> --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> @@ -391,7 +391,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
>
>        freqs.old = perf->states[perf->state].core_frequency * 1000;
>        freqs.new = data->freq_table[next_state].frequency;
> -       for_each_cpu(i, cmd.mask) {
> +       for_each_cpu(i, policy->cpus) {
>                freqs.cpu = i;
>                cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
>        }
> @@ -407,7 +407,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
>                }
>        }
>
> -       for_each_cpu(i, cmd.mask) {
> +       for_each_cpu(i, policy->cpus) {
>                freqs.cpu = i;
>                cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
>        }
> --
> 1.6.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/