Re: [PATCH 1/2]: mark ptrace_traceme static

From: Christoph Hellwig
Date: Wed Apr 28 2010 - 07:46:07 EST


Any reason this never made it to Linus?

On Mon, Feb 01, 2010 at 08:18:55PM +0100, Christoph Hellwig wrote:
> It's not used outside of ptrace.c, so no need to allow access to it.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Index: linux-2.6/include/linux/ptrace.h
> ===================================================================
> --- linux-2.6.orig/include/linux/ptrace.h 2010-01-26 18:02:46.745004926 +0100
> +++ linux-2.6/include/linux/ptrace.h 2010-01-26 18:02:51.759268161 +0100
> @@ -81,7 +81,6 @@
>
>
> extern long arch_ptrace(struct task_struct *child, long request, long addr, long data);
> -extern int ptrace_traceme(void);
> extern int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len);
> extern int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len);
> extern int ptrace_attach(struct task_struct *tsk);
> Index: linux-2.6/kernel/ptrace.c
> ===================================================================
> --- linux-2.6.orig/kernel/ptrace.c 2010-01-26 18:02:55.627012005 +0100
> +++ linux-2.6/kernel/ptrace.c 2010-01-26 18:04:22.163015407 +0100
> @@ -220,7 +220,7 @@ out:
> * Performs checks and sets PT_PTRACED.
> * Should be used by all ptrace implementations for PTRACE_TRACEME.
> */
> -int ptrace_traceme(void)
> +static int ptrace_traceme(void)
> {
> int ret = -EPERM;
>
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/