Re: [PATCH 07/13] drivers/staging/rtl8187se: Hoist assign from if

From: Greg KH
Date: Wed Apr 28 2010 - 14:36:56 EST


On Wed, Mar 24, 2010 at 10:17:01PM -0700, Joe Perches wrote:
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> @@ -1554,7 +1554,8 @@ ieee80211_rx_auth_rq(struct ieee80211_device *ieee, struct sk_buff *skb)
> //IEEE80211DMESG("Rx probe");
> ieee->softmac_stats.rx_auth_rq++;
>
> - if ((status = auth_rq_parse(skb, dest))!= -1){
> + status = auth_rq_parse(skb, dest);
> + if (status!= -1) {

Careful that you don't add new coding style issues to a staging driver
:)

I've fixed this up in the patch...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/