RE: [RFC PATCH 1/4] Mobile security processor driver

From: Epshteyn, Eugene
Date: Fri Apr 30 2010 - 13:43:43 EST


Hi Greg,

Mark asked me to post the patches for him.

These patches are on 2.6.34 with the 0415 next patch.

We were hoping to get more comments from people to add to TODO list, so that the vendor can plan their work to fix the issues and make the driver more acceptable to the community. The driver already went through some clean-up, but much more work is still needed.

Thanks,

--Eugene

-----Original Message-----
From: Greg KH [mailto:greg@xxxxxxxxx]
Sent: Wednesday, April 28, 2010 8:36 PM
To: Epshteyn, Eugene
Cc: linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [RFC PATCH 1/4] Mobile security processor driver

On Wed, Apr 28, 2010 at 04:10:34PM -0700, Epshteyn, Eugene wrote:
> >From ea67f69e70e5a8c6e50db3f1d8b62cd52d816bc6 Mon Sep 17 00:00:00 2001
> From: Mark Allyn <mark.a.allyn@xxxxxxxxx>
> Date: Wed, 28 Apr 2010 14:33:16 -0700
> Subject: RFC [PATCH 1/4] staging: sep: header file updates for 12/09 software release
>
> Signed-off-by: Mark A. Allyn <mark.a.allyn@xxxxxxxxx>

Why are you posting Mark's patches?

There is no description of what these patches actually do.

Are you wanting them to be applied?

Why have you listed all of the patches with the same subject?

What exactly are you expecting to happen here?

totally confused,

greg k-h


p.s., I think this patch is completly wrong, based on one part:

> @@ -25,401 +31,576 @@
> *
> * CHANGES:
> *
> - * 2009.06.26 Initial publish
> + * 2010.01.08 Initial publish

the code was already published, this can't be an "initial publication"
again :)

What did you diff these against?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/