[PATCH] Remove tosa_battery driver (was: Re: [PATCH] tosa_battery:fix FTBFS bug due to driver_data access)

From: Anton Vorontsov
Date: Fri Apr 30 2010 - 14:14:21 EST


On Tue, Apr 27, 2010 at 03:48:35PM -0700, Andrew Morton wrote:
> On Tue, 27 Apr 2010 17:18:22 +0400
> Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> wrote:
>
> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> > ---
> > drivers/power/tosa_battery.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Please don't send unchangelogged patches.
>
> Please don't send patches which require recipients to go googling
> acronyms to work out wtf you're up to.
>
> <googles the acronym>
>
> Ah, it appears to be a build fix.

It seems that the driver isn't buildable since 2.6.32
(i.e. commit b4028437 "Driver core: move dev_get/set_drvdata to
drivers/base/dd.c").

Also, IIRC it was deprecated in favor of wm97xx_battery.c
driver.

So, I'm not picking this patch for 2.6.34, it's not a
new regression, and the driver is probably needs to be
removed.

Any objections on the patch down below?

- - - -