RE: [PATCH] firmware_class: fix memory leak - free allocated pages

From: Winkler, Tomas
Date: Fri Apr 30 2010 - 14:40:24 EST




> -----Original Message-----
> From: David Woodhouse [mailto:dwmw2@xxxxxxxxxxxxx]
> Sent: Thursday, April 29, 2010 8:54 PM
> To: Greg KH
> Cc: Winkler, Tomas; linux-kernel@xxxxxxxxxxxxxxx; Johannes Berg; Ming Lei;
> Catalin Marinas
> Subject: Re: [PATCH] firmware_class: fix memory leak - free allocated pages
>
> On Thu, 2010-04-29 at 15:54 +0100, Greg KH wrote:
> > On Thu, Apr 29, 2010 at 03:40:21PM +0300, Tomas Winkler wrote:
> > > fix memory leak introduced by 6e03a201bbe patch:
> > > firmware: speed up request_firmware()
> >
> > Who originally wrote this patch, Kay?
>
> It's kind of a joint effort. I think it's probably mine by a fairly
> narrow majority.
>
> > If so, Tomas, please put a "From:" line at the top of the patch with
> > the author's name so we get it right when commiting it.
>
> And don't make up Signed-off-by lines. Although you can have that one of
> mine now you've got it (since you've actually tested it).

I added firmware_free_data function to the original patch, would you mind to review it, please.

Thanks
Tomas
>
> --
> David Woodhouse Open Source Technology Centre
> David.Woodhouse@xxxxxxxxx Intel Corporation

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i