Re: [PATCH] trivial: use (C) instead of \251

[Ingo Molnar]

* Jiri Kosina <jkosina@xxxxxxx> wrote:

> On Fri, 30 Apr 2010, Ingo Molnar wrote:
> 
> > > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
> > > > causes annoying problems with some editors and tools.  Use (C)
> > > > instead.
> > > > 
> > > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > > > Cc: Paul Mackerras <paulus@xxxxxxxxxxx>
> > > > ---
> > > > I'm not really sure this would survive transport over mail in
> > > > appliable form, attaching the patch too just in case.
> > > 
> > > It didn't survive :) But it was easy enough to fix by hand. Applied, 
> > > thanks Tejun.
> > 
> > NAK.
> > 
> > A similar patch was sent a few weeks ago, it was objected to and rejected - 
> > the copyright character was used for legal reasons.
> 
> Well, Paul himself stated that according to their lawyer department, 
> "Copyright" (which is there) is enough. So it made sense to remove invalid 
> (at least in some sense) character.
> 
> Also zillion of other files copyrighted by Paul contain "Copyright (C)".
> 
> If we really want this character there then, why not rather in UTF-8, so 
> that it works flawlessly?

It might be fine but i havent seen Paul reply to this thread - and this is my 
point: _you_ should have waited for an ack from Paul (who is co-maintaining 
that file) before applying it. The commit doesnt have it:

 commit 62006c58a9a2d8b72b5b65301965bc444d43e22c
 Author: Tejun Heo <tj@xxxxxxxxxx>
 Date:   Wed Apr 28 11:30:31 2010 +0200

    trivial: use (C) instead of \251
    
    The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
    causes annoying problems with some editors and tools.  Use (C)
    instead.
    
    Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
    Cc: Paul Mackerras <paulus@xxxxxxxxxxx>
    Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

We dont just go and change people's copyright notices, no matter how trivial 
it may seem ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/