Re: [PATCH 7/8] padata: Flush the padata queues actively

[Andrew Morton]

On Thu, 29 Apr 2010 14:44:26 +0200
Steffen Klassert <steffen.klassert@xxxxxxxxxxx> wrote:

> +static void padata_flush_queues(struct parallel_data *pd)
> +{
> +	int cpu;
> +	struct padata_queue *queue;
> +
> +	for_each_cpu(cpu, pd->cpumask) {
> +		queue = per_cpu_ptr(pd->queue, cpu);
> +		flush_work(&queue->pwork);
> +	}
> +
> +	del_timer_sync(&pd->timer);
> +
> +	if (atomic_read(&pd->reorder_objects))
> +		padata_reorder(pd);

padata_reorder() can fail to do anything, if someone else is holding
pd->lock.  What happens then?


> +	for_each_cpu(cpu, pd->cpumask) {
> +		queue = per_cpu_ptr(pd->queue, cpu);
> +		flush_work(&queue->swork);
> +	}
> +	BUG_ON(atomic_read(&pd->refcnt) != 0);
> +}

Are we safe against cpu hot-unplug in this code?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/