Re: [PATCH linux-next v4 2/2] ixgbe: Example usage of the new IRQaffinity_hint callback

[Peter P Waskiewicz Jr]

On Fri, 30 Apr 2010, Thomas Gleixner wrote:

> On Fri, 30 Apr 2010, Peter P Waskiewicz Jr wrote:
> > +	for (i = 0; i < num_q_vectors; i++) {
> > +		struct ixgbe_q_vector *q_vector = adapter->q_vector[i];
> > +		/* release the CPU mask memory */
> > +		free_cpumask_var(q_vector->affinity_mask);
> > +		/* clear the affinity_mask in the IRQ descriptor */
> > +		irq_set_affinity_hint(adapter->msix_entries[i].vector, NULL);
>
> Freeing the mask _AFTER_ clearing the hint might be a worthwhile
> exercise :)

Crap.  I had it reversed before, then when I dropped the unregister call 
it got swapped.  I'll fix it on the official submission for this one.

This patch is just an example patch, not to be merged just now.  Once the 
IRQ side is merged, and DaveM has that pulled into a tree, I'll send an 
official ixgbe patch using the API.  But I'll be sure to have this fixed 
before sending. :-)

-PJ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/