Re: [PATCH] fs: use kmalloc() to allocate fdmem if possible

[Avi Kivity]

On 05/03/2010 10:05 AM, Changli Gao wrote:
> On Mon, May 3, 2010 at 2:06 PM, Avi Kivity<avi@xxxxxxxxxx>  wrote:
>    
> > My point is, vmalloc() and vfree should do this, not their callers:
> >
> > vmalloc(size):
> >     if (size<= PAGE_SIZE)
> >         return kmalloc(size, GFP_KERNEL);
> >     ...
> >
> > vfree(p):
> >     if (!is_vmalloc_addr(p) {
> >         kfree(p);
> >         return;
> >     }
> >     ...
> >      
> I think we should not change vmalloc/vfree, and you can invent new
> memory APIs, such as malloc()/free().
>    

Why?

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/