Re: [PATCH 2/2] mm: fix race between shift_arg_pages and rmap_walk

[Linus Torvalds]

On Mon, 3 May 2010, Linus Torvalds wrote:
> 
> It looks like it makes execve() do a totally insane "create and then 
> immediately destroy temporary vma and anon_vma chain" for a case that is 
> unlikely to ever matter. 
> 
> In fact, for a case that isn't even normally _enabled_, namely migration.
> 
> Why would we want to slow down execve() for that?

Alternate suggestions:

 - clean up the patch so that it is explicitly abouy migration, and 
   doesn't even get enabled for anything else.

 - make the migration code take the VM lock for writing (why doesn't it 
   already?) and never race with things like this in the first place.

 - explain why the new code isn't any slower.

Hmm?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/