Re: [PATCH] perf: implement recording/reporting per-cpu samples

From: Arun Sharma
Date: Mon May 03 2010 - 16:53:27 EST


On Mon, May 3, 2010 at 1:42 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Mon, 2010-05-03 at 13:38 -0700, Arun Sharma wrote:
> > Enable PERF_SAMPLE_CPU by default. Implement --sort cpu.
>
> Why? The downside is that you unconditionally grow each sample and thus
> increase the overhead for something that doesn't make sense for the
> normal (task-inherit) case.

In a shared multi-core environment, users want to analyze why their
program was slow. In particular, if the code ran slower only on
certain CPUs due to interference from other programs or kernel
threads, they want to know that.

But that's just our use case. The patch is mostly about --sort cpu
option. If you want to drop the part that enables PERF_SAMPLE_CPU by
default, that's fine by me.

-Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/