Re: [PATCH] perf_event: Use UTF-8 copyright symbol instead of \251

From: Ingo Molnar
Date: Tue May 04 2010 - 02:51:13 EST



* Jiri Kosina <jkosina@xxxxxxx> wrote:

> On Sat, 1 May 2010, Paul Mackerras wrote:
>
> > As noted by Tejun Heo, the latin-1 copyright character \251 is invalid
> > in ASCII or UTF-8. This changes the character to its UTF-8 encoding
> > in order to avoid problems with editors and other tools.
> >
> > Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>
> > ---
> > diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> > index 9dbe8cd..d46a277 100644
> > --- a/kernel/perf_event.c
> > +++ b/kernel/perf_event.c
> > @@ -4,7 +4,7 @@
> > * Copyright (C) 2008 Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > * Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
> > * Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <pzijlstr@xxxxxxxxxx>
> > - * Copyright ??? 2009 Paul Mackerras, IBM Corp. <paulus@xxxxxxxxxxx>
>
> Umm ... this looks odd.

Yeah, and it didnt apply when i tried to.

> > + * Copyright ?? 2009 Paul Mackerras, IBM Corp. <paulus@xxxxxxxxxxx>
>
> This seems to add \251 again :) Maybe some of your tools got confused
> enough?
>
> Anyway, I have dropped the patch from Tejun for now.

Alternatively you could pick up Paul's patch on top of Tejun's if you have
already pushed the commit ID out and want to avoid a rebase.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/