Re: USB_SERIAL_KEYSPAN_* dependency on FIRMWARE_IN_KERNEL

[Michal Marek]

On Wed, Apr 28, 2010 at 11:24:27PM +0200, Michal Marek wrote:
> Hi David,
> 
> I recently disabled CONFIG_FIRMWARE_IN_KERNEL in the default openSUSE
> kernels (as no built-in driver needs firmware and the initrd takes care
> of the modules), but this disabled all the CONFIG_USB_SERIAL_KEYSPAN_*
> options, because there is
> 
> config USB_SERIAL_KEYSPAN_MPR
>         bool "USB Keyspan MPR Firmware"
>         depends on USB_SERIAL_KEYSPAN && FIRMWARE_IN_KERNEL
> etc
> 
> in drivers/usb/serial/Kconfig, added in 2971c57 by you. Is there a
> reason for this dependency or shouldn't this rather depend on FW_LOADER?

I found another problem, the kconfig options to select the firmware
files are boolean, so scripts/Makefile.fwinst assumes that the firmware
is meant for a built-in driver and doesn't install it during
modules_install. This patch should fix that.

Michal