Re: [PATCH 1/3] p9auth: split core function out of some set*{u,g}id functions

[David Howells]

Serge E. Hallyn <serue@xxxxxxxxxx> wrote:

> Break the core functionality of set{fs,res}{u,g}id into cred_setX
> which performs the access checks based on current_cred(), but performs
> the requested change on a passed-in cred.
> 
> Export the helpers, since p9auth can be compiled as a module.  It
> might be worth not allowing modular p9auth to avoid having to export
> them.
> 
> Really the setfs{u,g}id helper isn't needed, but move it as
> well to keep the code consistent.
> 
> This patch also changes set_user() to use new->user->user_ns.  While
> technically not needed as all callers should have new->user->user_ns
> equal to current_userns(), it is more correct and may prevent surprises
> in the future.
> 
> Changelog:
> 	Apr 24: (David Howells) make cred_setresuid etc extern, and
> 		document the helpers in Documentation/credentials.txt.
> 
> Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>
Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/