Re: [PATCH 3/3] RFC: p9auth: add p9auth fs

[Serge E. Hallyn]

Quoting David Howells (dhowells@xxxxxxxxxx):
> Serge E. Hallyn <serue@xxxxxxxxxx> wrote:
> 
> > +	result = kzalloc(MAX_DIGEST_SIZE, GFP_KERNEL);
> > ...
> > +	ret = crypto_hash_digest(&desc, &sg, plain_text_size, result);
> 
> Does result have to be pre-cleared?
> 
> > +	user_buf = kzalloc(count+1, GFP_KERNEL);
> > +	if (!user_buf)
> > +		goto out;
> > +
> > +	if (copy_from_user(user_buf, buffer, count)) {
> 
> user_buf doesn't need preclearing.  It's just a waste of time.  This occurs
> three times.

Hm, yeah, the first doesn't need it at all, and the latter two
should just kmalloc and set user_buf[count] = '\0'.

thanks,

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/