Re: [PATCH] KEYS: Fix RCU handling in key_gc_keyring()

[Serge E. Hallyn]

Quoting David Howells (dhowells@xxxxxxxxxx):
> key_gc_keyring() needs to either hold the RCU read lock or hold the keyring
> semaphore if it's going to scan the keyring's list.  Given that it only needs
> to read the key list, and it's doing so under a spinlock, the RCU read lock is
> the thing to use.
> 
> Furthermore, the RCU check added in e7b0a61b7929632d36cf052d9e2820ef0a9c1bfe is
> incorrect as holding the spinlock on key_serial_lock is not grounds for
> assuming a keyring's pointer list can be read safely.  Instead, a simple
> rcu_dereference() inside of the previously mentioned RCU read lock is what we
> want.
> 
> Reported-by: Serge E. Hallyn <serue@xxxxxxxxxx>

You're obviously being far too kind.  In apparent trend for last night
I missed the lack of locking here.

> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Acked-by: Serge Hallyn <serue@xxxxxxxxxx>

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/