Re: nfs accesses of FAT fs folders causes deadlock on lock_super

From: OGAWA Hirofumi
Date: Tue May 04 2010 - 14:41:33 EST


Fredrick Prashanth John Berchmans <fredrickprashanth@xxxxxxxxx> writes:

> On Tue, May 4, 2010 at 3:32 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> On Mon, May 03, 2010 at 10:59:42PM -0700, Fredrick Prashanth John Berchmans wrote:
>>> The box was running kernel version 2.6.27.10.
>>> But I think the FAT code has not changed much.
>>
>> But the nfsd code has and now doesn't call lookup from the filldir
>> callback anymore.
>>
>>
>
> I see from nfsd code, it seems the compose_entry_fh still calls
> lookup_one_len, which is now
> called from encode_entryplus_baggage instead of entry_encode.
> Am I right?

As far as I can see, nfsd is buffering the result of readdir, then do
jobs (encode_fh, etc.) with it on other context of readdir.

Aren't you missing a buffering of nfsd_buffered_readdir()?

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/