Re: [PATCH 2/2] vgacon: use request_region(), not request_resource(),to set BUSY

[H. Peter Anvin]

On 05/04/2010 12:16 PM, Bjorn Helgaas wrote:
> On Tuesday, May 04, 2010 01:09:46 pm Linus Torvalds wrote:
>> On Tue, 4 May 2010, Bjorn Helgaas wrote:
>>> Drivers normally use request_region() to mark the region busy so it won't
>>> be used by anybody else.  Previously, we used request_resource(), which
>>> doesn't mark the VGA regions busy.
>>>
>>> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
>>
>> Hmm. I don't object, but unless there is some crazy regression, there's no
>> way I will take something like this outside the merge window. Who knows
>> what odd frame buffer driver is out there that just depended on the fact
>> that it could also register that VGA area?
>>
>> Probably no such thing exists, but it's why I want these kinds of things
>> during the merge window. And obviously preferably through something like
>> the PCI merge tree, but that's a different issue.
> 
> Yep, I was intending for after .34.  I couldn't figure out where
> to send it, but I'll be happy to send it to Jesse.
> 

I would vote for Jesse's tree.  If Jesse doesn't want it I'll take it.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/