Re: [PATCH tip/core/rcu 21/48] remove all rcu headinitializations, except on_stack initializations

From: Paul E. McKenney
Date: Tue May 04 2010 - 16:36:27 EST


On Tue, May 04, 2010 at 03:27:03PM -0500, Matt Mackall wrote:
> On Tue, 2010-05-04 at 13:19 -0700, Paul E. McKenney wrote:
> > From: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> >
> > Remove all rcu head inits. We don't care about the RCU head state before passing
> > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> > keep track of objects on stack.
>
> Please document that distinction at the definition of INIT_RCU_HEADS,
> otherwise we're sure to see creep.

Hello, Matt,

RCU_HEAD_INIT() is no more. Or will be no more after this patchset.
However, now that you mention it, we do need docbook comments for
init_rcu_head_on_stack() and friends. I will fix that.

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/