Re: [Nios2-dev] [PATCH 2/2] serial: Add driver for the Altera UART

[Ian Abbott]

On 06/05/10 12:09, Ian Abbott wrote:
> On 06/05/10 11:44, Ian Abbott wrote:
>> Those four functions shouldn't grab port->lock because the caller in
>> serial_core.c grabs it before calling them.
> 
> Oh, and that also applies to altera_uart_set_mctrl() - the caller grabs
> port->lock before calling it.

And altera_uart_get_mctrl().

(And for completeness, altera_uart_enable_ms() but the current
implementation doesn't grab it anyway as it's just an empty function.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/