Re: [PATCH -tip] x86,perf: P4 PMU -- protect sensible proceduresfrom preemption

[Steven Rostedt]

On Thu, 2010-05-06 at 11:45 +0400, Cyrill Gorcunov wrote:
> On Thursday, May 6, 2010, Ingo Molnar <mingo@xxxxxxx> wrote:

> >> the thing are that p4 is only snippet here which is sensible to preemtion,
> >> and hw_perf_event_init is executing with preemtion off (but i could miss the
> >> details here, dont have code under my hands at moment, so PeterZ help is
> >> needed ;) but more important reason why i've saved get/put here is that
> >> otherwise i would not have rights to put tested-by tag, since it would not
> >> be the patch Steven has tested. We could make a patch on top of this one, or
> >> we could drop this one, make new with explicit preemt off in caller and use
> >> smp_processor_id in p4 schedule routine. What is preferred?
> >
> > We want the one with the least runtime overhead. These are instrumentation
> > routines, so we want to optimize them as much as possible.


Yeah, my point was either disable preemption or keep the checks. In
other words, if you don't disable preemption, do not use
raw_smp_procesor_id(), because then we will not catch it if it changes
in the future.


> ok, Ingo, dont apply this patch then for a while.

Send another patch, I'll test it again ;-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/