RE: [linux-pm] [PATCH v2] [RFC] ehci: Disable wake on overcurrent(WKOC_E) and disconnect (WKDISC_E)

From: Alan Stern
Date: Thu May 06 2010 - 12:06:48 EST


On Thu, 6 May 2010, Du, Alek wrote:

> Hi Alan,
>
> >With this patch, _none_ of the wakeup bits are enabled. That should
> >work, right?
> >
> I guess so, but if no wakeup bits set, how to handle remote wakeup case? Seems you removed remote wakeup case?

The wakeup bits get set later, in ehci_set_wakeup_flags().

The point is that the wakeup bits take effect only when the controller
leaves D0. But ehci_bus_suspend() is called when the root hub is
suspended, which happens first. So at that time the wakeup bits aren't
needed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/