Re: indiscriminate get_maintainer.pl usage

[Joe Perches]

On Thu, 2010-05-06 at 08:42 -0700, Davide Libenzi wrote:
> On Thu, 6 May 2010, Stefan Richter wrote:
> > > I should add --nogit option.
> > The script does get some useful information out of git (but obviously
> > also some questionable).

Stefan, I think that's the price you pay for fame.
Try to do good, get more unsolicited email.

> > --roles and --rolestats give away some more data...
> > $ scripts/get_maintainer.pl --rolestats -f fs/eventpoll.c
> > Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> (maintainer:FILESYSTEMS (VFS...)
> > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> (commit_signer:2/6=33%)
> > "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> (commit_signer:2/6=33%)
> > Davide Libenzi <davidel@xxxxxxxxxxxxxxx> (commit_signer:2/6=33%)
> > Roland Dreier <rolandd@xxxxxxxxx> (commit_signer:1/6=17%)
> > Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> (commit_signer:1/6=17%)
> > linux-fsdevel@xxxxxxxxxxxxxxx (open list:FILESYSTEMS (VFS...)
> > linux-kernel@xxxxxxxxxxxxxxx (open list)
> > 
> > ...but still don't distinguish between signed-off-by or reviewed-by on
> > one hand, and reported-by and tested-by on the other hand.  Cc'ing a
> > reporter or tester would only make sense if the patch changes something
> > that directly affects the reporter's/ tester's setup, e.g. reworks a
> > provisional fix.
> 
> I have always maintained that code w/out the need of explicit entry in the 
> MAINTAINERS file.  For isolated files people usually include the copyright 
> owners and the ones listed in the comment header in general.
> No problem in being explicitly listed if this causes noise during bug 
> reporting.

There is also the --git-blame option for patches, but blame
is also only a semi-useful tool, as it could show cleanup patches
on individual as authors.

Another option to get_maintainers is --file-emails which looks
inside a file for email addresses.

Right now, the default for # of git commits signed to be
added to the CC list is 1.  It's possible to change the default.

    --git-min-signatures => number of signatures required (default: 1)
    --git-max-maintainers => maximum maintainers to add (default: 5)
    --git-min-percent => minimum percentage of commits required (default: 5)

Maybe some fine-tuning of the defaults could be useful.

Suggestions?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/