Re: linux-next: Tree for May 6 (nouveau)

[Len Brown]

> When CONFIG_ACPI_BUTTON=m:
> 
> drivers/built-in.o: In function `nouveau_connector_detect':
> nouveau_connector.c:(.text+0x1d81cf): undefined reference to `acpi_lid_open'
> 
> 
> #ifdef CONFIG_ACPI
> 		if (!nouveau_ignorelid && !acpi_lid_open())
> 			status = connector_status_unknown;
> #endif
> 
> 
> Do you want that to be
> #ifdef CONFIG_ACPI_BUTTON
> ?
> That will still only be built when CONFIG_ACPI_BUTTON=y (not =m).
> 

intel_lvds.c seems to handle this issue without #ifdefs
by including acpi/button.h

cheers,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/