Re: [PATCH 2/2] mm,migration: Fix race between shift_arg_pages andrmap_walk by guaranteeing rmap_walk finds PTEs created within the temporarystack
From: Linus Torvalds
Date: Thu May 06 2010 - 21:44:38 EST
On Fri, 7 May 2010, Mel Gorman wrote:
>
> Page migration requires rmap to be able to find all migration ptes
> created by migration. If the second rmap_walk clearing migration PTEs
> misses an entry, it is left dangling causing a BUG_ON to trigger during
> fault. For example;
So I still absolutely detest this patch.
Why didn't the other - much simpler - patch work? The one Rik pointed to:
http://lkml.org/lkml/2010/4/30/198
and didn't do that _disgusting_ temporary anon_vma?
Alternatively, why don't we just take the anon_vma lock over this region,
so that rmap can't _walk_ the damn thing?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/