Re: [PATCH 1/3] Add flag to identify block swap devices

From: jassi brar
Date: Fri May 07 2010 - 04:03:49 EST


On Fri, May 7, 2010 at 4:25 PM, Nitin Gupta <ngupta@xxxxxxxxxx> wrote:
> Added SWP_BLKDEV flag to distinguish block and regular file backed
> swap devices. We could also check if a swap is entire block device,
> rather than a file, by:
> S_ISBLK(swap_info_struct->swap_file->f_mapping->host->i_mode)
> but, I think, simply checking this flag is more convenient.
This might make it convenient for now but is likely to increase complexity and
redundancy. Why not define a macro/inline to figure that out?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/