[PATCH] perf: fix raw sample size if no sampling data is attached
From: Robert Richter
Date: Fri May 07 2010 - 11:32:23 EST
On 19.04.10 14:19:57, Stephane Eranian wrote:
> > + perf_sample_data_init(&data, 0);
> > + if (event->attr.sample_type & PERF_SAMPLE_RAW) {
> > + for (i = 1; i < size; i++)
> > + rdmsrl(msr++, *buf++);
> > + raw.size = sizeof(u64) * size;
> > + raw.data = buffer;
> > + data.raw = &raw;
> > + }
> > +
>
> Need to add the padding: raw.size = sizeof(u64) * size + sizeof(u32);
>
> > + regs = *iregs; /* later: update ip from ibs sample */
> > +
> > + if (perf_event_overflow(event, 1, &data, ®s))
During code review I found a bug in perf_output_sample(). A fix is
below.
> > + x86_pmu_stop(event);
> > + else
> > + __x86_pmu_enable_event(&event->hw, reenable);
> > +
> > + return 1;
> > +}
--