Re: [PATCH] ad7877: fix spi word size to 16 bit

[Mike Frysinger]

On Fri, May 7, 2010 at 05:41, Daniel GlÃckner wrote:
> On 05/06/2010 08:26 PM, Mike Frysinger wrote:
>> i think it'd be a better idea to do something like:
>> Â if (spi->bits_per_word != 16) {
>> Â Â if (spi->bits_per_word) {
>> Â Â Â dev_err(&spi->dev, "Invalid SPI settings; bits_per_word must be 16\n");
>> Â Â Â return -EINVAL;
>> Â Â }
>> Â Â spi->bits_per_word = 16;
>> Â Â spi_setup(spi);
>> Â }
>
> There is no way to set bits_per_word using struct spi_board_info. The
> description of that structure in spi.h explicitly lists the wordsize as
> one of the parameters drivers should set themself in probe().
>
> Only struct bfin5xx_spi_chip allows to set this value in the board code.

an obvious shortcoming in the SPI framework that should be fixed, but
that doesnt make any difference to the above code now does it ?  it'll
operate correctly regardless of the SPI bus master.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/