Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wallclock device

From: Joe Perches
Date: Fri May 07 2010 - 14:51:13 EST


On Fri, 2010-05-07 at 10:41 -0700, Jacob Pan wrote:
> + printk(KERN_INFO "vRTC: sec: %d min: %d hour: %d day: %d "
> + "mon: %d year: %d\n", sec, min, hour, mday, mon, year);
> +

Even though many of the rtc drivers print this way, it seems
a very backwards way of presenting time to me.

I think "yyyy-mm-dd hh:mm:ss" is a better representation, more
compact and readable.

Also KERN_INFO may not be good, maybe KERN_DEBUG or pr_debug?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/