Re: [PATCH] perf: fix raw sample size if no sampling data isattached

[Robert Richter]

On 07.05.10 17:28:35, Robert Richter wrote:
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index 9dbe8cd..f6ddae9 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -3229,7 +3229,7 @@ void perf_output_sample(struct perf_output_handle *handle,
>  				u32	size;
>  				u32	data;
>  			} raw = {
> -				.size = sizeof(u32),
> +				.size = 0,
>  				.data = 0,

Uhhh, this padding data was completly hidden to me by a SEP field. It
became visible to me with a far distance of at least 4km and only from
the corner of my eye. So, *now* I realized that size is the size of
padding data, not the size header! Please ignore this, I shouln't send
patches at Friday afternoon.

-Robert

>  			};
>  			perf_output_put(handle, raw);

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/