Re: [PATCH] Check kmalloc return value before use the buffer

[Nigel Cunningham]

Hi again.

On 08/05/10 04:57, Linus WALLEIJ wrote:
> [Steven]
>
> > the code in arch/arm/mach-u300/dummyspichip.c is
> >
> >      bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
> >      if (bigtxbuf_virtual == NULL) {
> >          status = -ENOMEM;
> >          goto out;
> >      }
> >      bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
> >
> >
> > if kmalloc memory space for bigrxbuf_virtual is NULL, when it have
> > kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc
> > memory for bigtxbuf_virtual success and kmalloc memory for
> > bigrxbuf_virtual faild,i think we must kfree  bigtxbuf_virtual memory
>
> Ha, I also misread tx for rx, sorry.

I've just looked again, and the original version did have rx in the 
test. We weren't seeing things :)

> Acked-by: Linus Walleij<linus.walleij@xxxxxxxxxxxxxx>

Acked-by: Nigel Cunningham <nigel@xxxxxxxxxxxx>

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/