Re: [RFC][PATCH 2/9] perf: core, remove hw_perf_event_init

[Lin Ming]

On Mon, 2010-05-10 at 17:42 +0800, Peter Zijlstra wrote:
> On Mon, 2010-05-10 at 17:26 +0800, Lin Ming wrote:
> > A new field "pmu_id" is added to struct perf_event_attr.
> > 
> > 2 new functions: perf_event_register_pmu, perf_event_lookup_pmu
> > perf_event_register_pmu: the pmu registration facility
> > perf_event_lookup_pmu: lookup the pmu via the passed in event->attr.pmu_id.
> > 
> > A new api pmu->init_event to replace hw_perf_event_init
> 
> Another problem, this patch breaks all of perf by removing the weak call
> before there is a replacement.
> 
> Please rework such that there is a smooth transition.

OK, I'll rework

> 
> Also, for compatibilities sake, the cpu pmu will be required to get
> pmu_id==0, this doesn't provide that.
> 

Will provide that.

Thanks,
Lin Ming

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/