Re: [PATCHv4 1/4] procfs: Introduce socinfo under /proc

From: Felipe Balbi
Date: Mon May 10 2010 - 08:56:49 EST


On Mon, May 10, 2010 at 01:13:00PM +0200, ext Paul Mundt wrote:
You'll still need the show function, but all of the rest of this is just
duplicating what single_open() already does. If the socinfo string is
static you may also want to rework this a bit so you can just stash the
string in the proc_dir_entry private data. Combine this with something
like kstrdup() and you'll save yourself a bit of stack while you're at
it.

doesn't ksrtdup() cause memleak ?? Or is it only when used with module parameters ??

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/