Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wallclock device

[Feng Tang]

On Tue, 11 May 2010 02:22:15 +0800
"H. Peter Anvin" <hpa@xxxxxxxxx> wrote:

> On 05/10/2010 02:17 AM, Feng Tang wrote:
> > 
> > Thank you all for the comments. please review this follow-on patch.
> > 
> > - Feng
> 
> That doesn't move it to common code, though.  I'd rather see existing
> common style used, then merged (centralized) and *then* the style
> corrected.
> 
> 	-hpa

Hi Peter,

The reason I didn't move it to rtc common code is, this vrtc.c sits in
arch/x86/kernel/ and better not to depend on drivers/rtc, as drivers/rtc
may not be always enabled in kernel configuration.

I also have another general driver for vrtc which will be in drivers/rtc/,
just like general x86 kernel which has a rtc.c in arch/ and a rtc-cmos.c
in drivers/rtc, I will clean my code up and try to move these funcs to a
common code. 

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/