Re: [trivial PATCH] arch/x86: Remove unnecessary returns from voidfunction()'s

From: H. Peter Anvin
Date: Tue May 11 2010 - 20:48:57 EST


On 05/11/2010 05:39 PM, Joe Perches wrote:
> This patch removes from arch/x86/ all the unnecessary
> return; statements that precede the last closing brace of
> void functions.
>
> It does not remove returns that are immediately
> preceded by a label as gcc doesn't like that.

And the point of this is?

I fail to see how this improves the clarity of the code one iota, and
isn't anything but just churn.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/