Re: [trivial PATCH] arch/x86: Remove unnecessary returns from voidfunction()'s

[Joe Perches]

On Tue, 2010-05-11 at 18:00 -0700, Joe Perches wrote:
> On Tue, 2010-05-11 at 17:41 -0700, H. Peter Anvin wrote:
> > On 05/11/2010 05:39 PM, Joe Perches wrote:
> > > This patch removes from arch/x86/ all the unnecessary
> > > return; statements that precede the last closing brace of
> > > void functions.
> > And the point of this is?
> > I fail to see how this improves the clarity of the code one iota, and
> > isn't anything but just churn.
> Most all kernel void functions don't use return before
> the closing brace.

Just a stat from arch/x86:

There may be a little over 2000 void functions in arch/x86/,
40 use returns before the trailing brace.

Call it churn or consistency, <shrug>.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/